Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uncovered a bug in the
js_object_mapwhich, in retrospect, is a bit obvious. There's nothing stopping v8 from re-using objects/addresses, so the@intFromPtr(obj.handle)cannot safely be used as a key in an identity map (well, I say it's obvious, but I'm still not sure about re-using the object/address after we've created a Persistent wrapper around it...). Instead of creating a lookup, we just always created the persisted version, possibly creating duplicates (which I don't see as an issue really).There's more to message passing than the MessageChannel and MessagePort, e.g.
window.postMessage), but little steps.